docs(delab): fix 'SubExp' -> 'SubExpr' namespace typo#834
Open
MukundaKatta wants to merge 1 commit intoleanprover:mainfrom
Open
docs(delab): fix 'SubExp' -> 'SubExpr' namespace typo#834MukundaKatta wants to merge 1 commit intoleanprover:mainfrom
MukundaKatta wants to merge 1 commit intoleanprover:mainfrom
Conversation
Contributor
|
Preview for this PR is ready! 🎉 (also as a proofreading version). built with commit a606c43. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The delaborators section of the reference manual (
Manual/NotationsMacros/Delab.lean, line 285) refers to the namespace `Lean.PrettyPrinter.Delaborator.SubExp`, but that namespace does not exist. The real namespace is `Lean.PrettyPrinter.Delaborator.SubExpr` — the same name that is `open`ed five lines above in the surrounding `leanSection`.Before:
```
The most important functions for working with subexpressions in delaborators are in the namespace `Lean.PrettyPrinter.Delaborator.SubExp`:
```
After:
```
The most important functions for working with subexpressions in delaborators are in the namespace `Lean.PrettyPrinter.Delaborator.SubExpr`:
```
Closes #828
Testing
Documentation-only one-character change. Verified:
Manual/NotationsMacros/Delab.lean:280already usesSubExpr(the correct namespace)getExpr,withAppFn,withAppArg,withAppFnArgs,withBindingBody) live underLean.PrettyPrinter.Delaborator.SubExpr